Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-spread: Ignore Array#join().concat() and (a + b).concat() #1859

Merged
merged 3 commits into from Jul 18, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jul 14, 2022

  • Consider foo.join() not an array
  • BinaryExpression can't be an array

Fixes #1809

@sindresorhus sindresorhus merged commit ab71971 into sindresorhus:main Jul 18, 2022
@fisker fisker deleted the string-concat branch July 18, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad auto fix when use join and concat with an array (unicorn/prefer-spread)
2 participants