Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-string-replace-all: Report all String#replace() when the pattern has g flag #1965

Merged
merged 8 commits into from Nov 17, 2022
Merged

prefer-string-replace-all: Report all String#replace() when the pattern has g flag #1965

merged 8 commits into from Nov 17, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Nov 16, 2022

Fixes #1948

@fisker fisker marked this pull request as ready for review November 16, 2022 13:13
fisker and others added 2 commits November 17, 2022 09:19
@fisker @sindresorhus
Update docs/rules/prefer-string-replace-all.md
0b017b7 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@fisker
Update prefer-set-size.js
d82f895
@sindresorhus sindresorhus merged commit 6316f05 into sindresorhus:main Nov 17, 2022
@fisker fisker deleted the g-flag branch November 17, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce .replaceAll() over .replace() when the pattern has g flag
2 participants
@fisker @sindresorhus