Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-typeof-undefined rule #1966

Merged
merged 14 commits into from Nov 20, 2022
Merged

Add no-typeof-undefined rule #1966

merged 14 commits into from Nov 20, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Nov 17, 2022

Fixes #1492

@fisker fisker mentioned this pull request Nov 17, 2022
Closed
fisker
fisker commented Nov 17, 2022
View reviewed changes
rules/no-typeof-undefined.js Outdated
const tokenBefore = sourceCode.getTokenBefore(binaryExpression);
if (needsSemicolon(tokenBefore, sourceCode, secondToken.value)) {
yield fixer.insertTextBefore(binaryExpression, ';');
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as

eslint-plugin-unicorn/rules/no-negated-condition.js

Line 105 in e4aaa42

const {test, parent} = node;
, but I'm not going to make a reusable function in this PR, will do later.

@fisker fisker marked this pull request as ready for review November 17, 2022 08:16
sindresorhus
sindresorhus requested changes Nov 19, 2022
View reviewed changes
docs/rules/no-typeof-undefined.md Outdated Show resolved Hide resolved
docs/rules/no-typeof-undefined.md Outdated Show resolved Hide resolved
docs/rules/no-typeof-undefined.md Outdated Show resolved Hide resolved
rules/no-typeof-undefined.js Outdated Show resolved Hide resolved
fisker and others added 3 commits November 20, 2022 23:29
@fisker @sindresorhus
Apply suggestions from code review
ef7f443 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@fisker
Update snapshot
a9328a1
@fisker
Fix description
aafb747
@sindresorhus sindresorhus merged commit d7f7341 into sindresorhus:main Nov 20, 2022
@fisker fisker deleted the no-typeof-undefined branch November 20, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: no-typeof-undefined
2 participants
@fisker @sindresorhus