Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-string-replace-all: Improve RegExp to string fix #1971

Merged
merged 11 commits into from Nov 19, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Nov 18, 2022

Add regjsparser to better understand RegExp.

I'm not sure how to persevere escape.

Should be able to imporve prefer-string-starts-ends-with with this module too.

@fisker fisker marked this pull request as ready for review November 18, 2022 10:40
@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@sindresorhus
Copy link
Owner

I'm not sure how to persevere escape.

Maybe leave a TODO comment about it as a future improvement?

@sindresorhus sindresorhus merged commit b844dbc into sindresorhus:main Nov 19, 2022
@fisker fisker deleted the regexp-parse branch November 19, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants