Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jsx and tsx to file check pattern for no empty file #2002

Merged
merged 6 commits into from Feb 1, 2023
Merged

Add jsx and tsx to file check pattern for no empty file #2002

merged 6 commits into from Feb 1, 2023

Conversation

Felix-kln
Copy link
Contributor

@Felix-kln Felix-kln commented Nov 30, 2022 •
edited by fisker

Adding support for jsx and tsx file pattern

Fixes #2001

fisker
fisker reviewed Nov 30, 2022
View reviewed changes
rules/no-empty-file.js Outdated Show resolved Hide resolved
Felix-kln and others added 2 commits November 30, 2022 14:01
@Felix-kln @fisker
Update rules/no-empty-file.js
6576667 
Co-authored-by: fisker Cheung <lionkay@gmail.com>
@fisker
Fix tests, add some upercase exts
c29834a
fisker
fisker approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sindresorhus sindresorhus merged commit ba1a00e into sindresorhus:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind left review comments

@sindresorhus sindresorhus sindresorhus left review comments

@fisker fisker fisker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No empty file check for tsx files
4 participants
@Felix-kln @silverwind @sindresorhus @fisker