Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-number-properties: Fix false positives #2050

Merged
merged 6 commits into from Mar 30, 2023
Merged

prefer-number-properties: Fix false positives #2050

merged 6 commits into from Mar 30, 2023

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Mar 10, 2023 •
edited

Fixes #2049

Also improved isLeftHandSide function, so also fixed edge cases in other rules.

@fisker fisker marked this pull request as ready for review March 10, 2023 09:47
@sindresorhus sindresorhus merged commit 124bfa7 into sindresorhus:main Mar 30, 2023
22 checks passed
@fisker fisker deleted the 2049 branch March 30, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong unicorn/prefer-number-properties report
2 participants
@fisker @sindresorhus