Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expiring-todo-comments #2077

Merged
merged 4 commits into from May 6, 2023
Merged

Fix expiring-todo-comments #2077

merged 4 commits into from May 6, 2023

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented May 6, 2023 •
edited

Fixes #2076

@fisker fisker marked this pull request as ready for review May 6, 2023 01:54
@fisker
Copy link
Collaborator Author

fisker commented May 6, 2023 •
edited

@sindresorhus I think we should do a patch release. The lint-test job can't be fixed without a new version of eslint-plugin-unicorn. Disabled for now.

@sindresorhus sindresorhus merged commit 6ee3687 into sindresorhus:main May 6, 2023
22 checks passed
sindresorhus pushed a commit that referenced this pull request May 6, 2023
@fisker @sindresorhus
Fix expiring-todo-comments (#2077)
7a6861a 
# Conflicts:
#	package.json
@fisker fisker deleted the eslint-840 branch May 6, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unicorn/expiring-todo-comments fails with eslint 8.40.0
2 participants
@fisker @sindresorhus