Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-thenable: Fix Object.fromEntries() check #2130

Merged
merged 3 commits into from
May 17, 2023
Merged

no-thenable: Fix Object.fromEntries() check #2130

merged 3 commits into from
May 17, 2023

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented May 17, 2023

Previously, we are checking the wrong pattern.

Object.fromEntries(['then', 1])

Should be

Object.fromEntries([
	['then', 1]
])

Found during #2126

@sindresorhus sindresorhus merged commit f3265b9 into sindresorhus:main May 17, 2023
21 checks passed
@fisker fisker deleted the no-thenable-from-entries branch May 17, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sindresorhus