You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have components called FAQPage.js, DIYWidget.js, etc. We're getting unicorn/filename-case errors on these, but I don't think we should.
I couldn't find an authoritative definition of what to do with acronyms-at-the-start-of-strings in pascal case online, or even an authoritative definition of pascal case generally. But I think it'd be better if this rule erred on the side of permissiveness, because changing the casing of a filename can be pretty disruptive, especially since Windows and Git track casing of filepaths differently.
So, given the general consensus on whether FAQPage is valid pascal case is that it's a matter of opinion, I think eslint-plugin-unicorn's opinion should be "yes" since that's a pretty legit component name.
If this would be wanted, maybe could be implemented with something along the lines of:
Related: #2141 - but I consider that more controversial because it relates to camel case.
The text was updated successfully, but these errors were encountered:
mmkal
changed the title
filename-case: pascaleCase should allow stuff like FAQPage.js
filename-case: pascalCase should allow stuff like FAQPage.js
Apr 5, 2024
We have components called
FAQPage.js
,DIYWidget.js
, etc. We're gettingunicorn/filename-case
errors on these, but I don't think we should.I couldn't find an authoritative definition of what to do with acronyms-at-the-start-of-strings in pascal case online, or even an authoritative definition of pascal case generally. But I think it'd be better if this rule erred on the side of permissiveness, because changing the casing of a filename can be pretty disruptive, especially since Windows and Git track casing of filepaths differently.
So, given the general consensus on whether
FAQPage
is valid pascal case is that it's a matter of opinion, I thinkeslint-plugin-unicorn
's opinion should be "yes" since that's a pretty legit component name.If this would be wanted, maybe could be implemented with something along the lines of:
Related: #2141 - but I consider that more controversial because it relates to camel case.
The text was updated successfully, but these errors were encountered: