Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for '/|/g can be optimized to //g' in the better-regex rule breaks regular expression syntax #2314

Open
haykam821 opened this issue Apr 7, 2024 · 0 comments

Comments

@haykam821
Copy link

An empty regular expression such as // is invalid and parsed as a line comment instead, which breaks other syntax within the code. I would expect the better-regex rule to not propose code with empty regular expressions.

The following is a minimal example:

const expression = /|/;

I would expect this expression to be corrected to something like:

const expression = /(?:)/;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant