Add prefer-negative-index rule
#417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
prefer-negative-index ruleprefer-negative-index rule
…-plugin-unicorn into rule/prefer-negative-index
fisker
changed the title
prefer-negative-index ruleprefer-negative-index rule
sindresorhus
requested changes
Nov 27, 2019
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
rules/prefer-negative-index.js
Outdated
| let after = sourceCode.getTokenAfter(node); | ||
|
|
||
| let start = node.range[0]; | ||
| let end = node.range[1]; |
There was a problem hiding this comment.
Suggested change
| let end = node.range[1]; | |
| let [start, end] = node.range; |
Same with the below.
There was a problem hiding this comment.
I forgot why I seperate them... maybe mistake
There was a problem hiding this comment.
assign can't do this, different ranges
There was a problem hiding this comment.
let [start, end] = [1, 2];
console.log(start, end);
//=> 1 2There was a problem hiding this comment.
I know this, already did
fisker
commented
Nov 27, 2019
| before = sourceCode.getTokenBefore(before); | ||
| after = sourceCode.getTokenAfter(after); | ||
| start = before.range[1]; | ||
| end = after.range[0]; |
There was a problem hiding this comment.
i mean these two line cant combine
There was a problem hiding this comment.
It was not clear that you were referring to this as you commented on the other code.
|
Nice 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #415