Make regex-shorthand rule use regexp-tree for regex literals

[jdanil]

Continuing on from #261 to fix #157.

• Updated to use regexp-tree to optimize for more cases.
• Updated error messages to include more detailed information.
• Fixed regex-shorthand code errors in eslint-plugin-unicorn.

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #157: The regex-shorthand rule has a false-negative

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[fisker]

wow, so many regexp in codebase can be optimized

[fisker]

looks the same as https://github.com/BrainMaestro/eslint-plugin-optimize-regex/blob/master/lib/rules/optimize-regex.js to me

[jdanil]

wow, so many regexp in codebase can be optimized

Yah a couple. Most of the changes are re-ordering though.

looks the same as https://github.com/BrainMaestro/eslint-plugin-optimize-regex/blob/master/lib/rules/optimize-regex.js to me

Yep. That's what #261 was based off of too. But just for regex literals. RegExp with string arguments is still using clean-regexp.

[fisker]

@jdanil off topic , how did you fix those RegExps? I'm not sure yarn lint error message is clear enough

[jdanil]

@jdanil off topic , how did you fix those RegExps? I'm not sure yarn lint error message is clear enough

I used the optimised regex from regexp-tree. The only problem I had with some of the optimised regex was that regexp-tree tries to order groups alphabetically I think. It would have symbols followed by alphanumeric characters, so some of the symbols needed to be escaped.

[fisker]

@jdanil I mean did you fix them by npm run lint --fix or ?

I put a message here, https://travis-ci.org/sindresorhus/eslint-plugin-unicorn/jobs/612730929#L266

But not sure is it clear

[jdanil]

@jdanil I mean did you fix them by npm run lint --fix or ?

I put a message here, https://travis-ci.org/sindresorhus/eslint-plugin-unicorn/jobs/612730929#L266

But not sure is it clear

Ohh. No I missed that script and comment.
I was actually surprised to see the updated rule running on the PR in travis!
I just updated all the issues it reported because I didn't know I could run the autofix.
Thanks for pointing it out 🙂

[fisker]

@jdanil thanks for your feedback.