Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex-shorthand #454

Merged
merged 1 commit into from Nov 30, 2019

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Nov 30, 2019

what I've done:

  1. simplify logic
  2. sort flags, regexp-tree do this by default, but missed in previous version
  3. ignore regex regexp-tree can't parse, can't find a case to test
  4. ignore regex with u flag that regexp-tree can't handle well, avoid crashing ESLint and suggestting wrong code

related PRs:
#452 was tring to ignore parse error
#451 after simplify logic, we caught a crash issue when running integration test, so move the fix into this one

fixes #446
fixes #447
fixes #448

@fisker fisker changed the title Simplify regex-shorthand logic WIP: Simplify regex-shorthand logic Nov 30, 2019
@fisker fisker force-pushed the simplify-regex-shorthand branch 5 times, most recently from adb8382 to b69e5ac Compare November 30, 2019 06:10
@fisker fisker changed the title WIP: Simplify regex-shorthand logic Update regex-shorthand Nov 30, 2019
@sindresorhus sindresorhus merged commit db41877 into sindresorhus:master Nov 30, 2019
@sindresorhus
Copy link
Owner

Thanks for fixing all the issues 👌

@fisker fisker deleted the simplify-regex-shorthand branch November 30, 2019 09:27
@jdanil
Copy link
Contributor

jdanil commented Dec 3, 2019

Thanks @fisker 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants