Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicorn/regex-shorthand vs eslint-plugin-optimize-regex #473

Closed
EvgenyOrekhov opened this issue Dec 9, 2019 · 1 comment
Closed

unicorn/regex-shorthand vs eslint-plugin-optimize-regex #473

EvgenyOrekhov opened this issue Dec 9, 2019 · 1 comment

Comments

@EvgenyOrekhov
Copy link
Contributor

What's the difference between unicorn/regex-shorthand and optimize-regex/optimize-regex from eslint-plugin-optimize-regex?

@fisker
Copy link
Collaborator

fisker commented Dec 17, 2019

currently there is not much difference for RegexLiteral, they are all based on regexp-tree

unicorn/regex-shorthand also optimize RegExp with string arguments, which eslint-plugin-optimize-regex doesn't.

unicorn/regex-shorthand disabled optimize for regex with u flag, because regexp-tree can't handle well

and we are planning add option for disabling of regexp character sorting #468

#437 (comment)

#454 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants