Fix invalid autofix with destructuring assignment in no-for-loops rule

[bmish]

Example (original):

for (let i = 0; i < arr.length; i++) {
  const { a, b } = arr[i];
  console.log(a, b);
}

Autofix (before this fix):

for (const element of arr) {
  console.log(a, b);
}

Autofix (after this fix):

for (const element of arr) {
  const { a, b } = element;
  console.log(a, b);
}

When arr[i] is used in a destructuring assignment, the entire assignment should not be removed (previous behavior), only arr[i] should be replaced with element (new behavior).

[fisker]

LGTM, but can we fix this to

for (const { a, b } of arr) {
  console.log(a, b);
}

if element is not used?

maybe we can keep removeRange, but do something with replacement

[bmish]

@fisker that's a good idea. However, since that is a much more involved fix, it's probably worth considering as a follow-up improvement.

[fisker]

sending a PR to your fork

[fisker]

@bmish

bmish#1

what do you think? can you merge it?

[bmish]

@fisker your improvement looks great, thank you! But I'm not sure how to merge it in my fork due to the conflicts. Perhaps you could just add the commit to this PR?

[fisker]

Good job, thank you! @bmish