Deprecate prefer-exponentiation-operator rule
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
force-pushed
the
deprecated-prefer-exponentiation-operator
branch
from
14ae67d
to
83208a8
Compare
gurpreetatwal
approved these changes
Dec 24, 2019
| t.is(Object.keys(usageRules).length - ignoredRules.length, ruleFiles.length, 'There are more rules in readme.md ## Usage than rule files.'); | ||
| t.is(Object.keys(rules).length, ruleFiles.length, 'There are more rules in readme.md ## Rules than rule files.'); | ||
| t.is(Object.keys(usageRules).length - ignoredRules.length, availableRules.length, 'There are more rules in readme.md ## Usage than rule files.'); | ||
| t.is(Object.keys(rules).length, availableRules.length, 'There are more rules in readme.md ## Rules than rule files.'); |
There was a problem hiding this comment.
Would it be worth it to add a check that ensures deprecated rules are described in the readme?
There was a problem hiding this comment.
I don't think it's really nessary.
sindresorhus
requested changes
Dec 30, 2019
readme.md
Outdated
|
|
||
| |Deprecated rule|Replaced by|Rule Details| | ||
| |:--|:--|:--| | ||
| |[unicorn/prefer-exponentiation-operator](docs/rules/prefer-exponentiation-operator.md)|[prefer-exponentiation-operator](https://eslint.org/docs/rules/prefer-exponentiation-operator)|Prefer the exponentiation operator over `Math.pow()`| |
There was a problem hiding this comment.
I don't think we should use a table for this. Markdown tables are annoying to edit and comes with little benefit here. Not every deprecated rule will have a replacement either. Better to just use a plain list.
…m:fisker/eslint-plugin-unicorn into deprecated-prefer-exponentiation-operator
fisker
force-pushed
the
deprecated-prefer-exponentiation-operator
branch
from
f158a41
to
9b288d8
Compare
fisker
force-pushed
the
deprecated-prefer-exponentiation-operator
branch
from
9b288d8
to
1d6aad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
unicorn/prefer-exponentiation-operatorrule, replace it with ESLint official ruleprefer-exponentiation-operatorI ran
prefer-exponentiation-operatorover our test cases, little difference:fixes #483