Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid autofix with array destructuring in no-for-loops rule #489

Merged
merged 1 commit into from Dec 30, 2019

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 27, 2019

Follow up #476 , #476 only fixed object destructuring, not array destructuring

fixes:​ #295

please check #295 (comment) first when review this PR

sorry, this didn't fixx #295

@fisker
Copy link
Collaborator Author

fisker commented Dec 27, 2019

//cc @bmish

@sindresorhus sindresorhus changed the title Fix invalid autofix with array destructuring in no-for-loops rule Fix invalid autofix with array destructuring in no-for-loops rule Dec 30, 2019
@sindresorhus sindresorhus merged commit 94345a3 into sindresorhus:master Dec 30, 2019
@fisker fisker deleted the follow-up-476 branch December 30, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants