prefer-node-remove: Only fix when expression is not used

[brettz9]

Fixes #497

I also have a minor update and very minor refactoring included with this PR. Let me know if you need them separated out.

[fisker]

LGTM, one comment

[brettz9]

Applied, thanks.

Btw, I'm getting issues when running npm run lint, even before my changes. But npm test and npm run integration are working.

[fisker]

@brettz9 If they are the some, can we add a function maybe isReturnValueUsed(or a better name) in /rules/utils?

[brettz9]

isReturnValueUsed seemed ok to me (couldn't think of anything else) so I've implemented.

I'm on a slow connection so I haven't been able to complete npm run integration locally this time, but I see it is passing on CI.

[brettz9]

actually, on further reflection, I'm thinking isValueUsed would be better, since it is not necessarily part of a return. I've added a commit to change, though feel free to revert.

[fisker]

Looks great, thank you very much.

I think prefer-modern-dom-apis also missing some check #362 (comment) , If you're interested, maybe you can help, just let you know, no pressure.

I also notice, prefer-modern-dom-apis checked nodeParentType === 'AssignmentExpression' and we don't do this check here, not sure if is it needed.

[brettz9]

Yes, indeed, nodeParentType === 'AssignmentExpression' was needed. I've added that and some tests.

And thanks for the heads up on prefer-modern-dom-apis.

[fisker]

Great, thanks again.