prefer-set-has: Ignore arrays only checking existence once
#706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
May 2, 2020
Comment on lines
+153
to
+154
| identifiers.length === 1 && | ||
| identifiers.every(identifier => !isMultipleCall(identifier, node)) |
There was a problem hiding this comment.
I use .every() on purpose, we might add option to ignore 2 :)
fisker
commented
May 2, 2020
rules/prefer-set-has.js
Outdated
Comment on lines
110
to
120
| const multipleCallNodeTypes = new Set([ | ||
| 'ForOfStatement', | ||
| 'ForStatement', | ||
| 'WhileStatement', | ||
| 'DoWhileStatement', | ||
| 'FunctionDeclaration', | ||
| 'FunctionExpression', | ||
| 'ArrowFunctionExpression', | ||
| 'ObjectMethod', | ||
| 'ClassMethod' | ||
| ]); |
There was a problem hiding this comment.
These types are all I got in mind could call .includes() multiple times. Maybe more from other parser, need feedback.
There was a problem hiding this comment.
Forgot ForInStatement, added in aaa3638.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696