Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw-new-error: Check MemberExpression customError #716

Merged

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented May 4, 2020

  • Check MemberExpression, before, throw lib.Error() is not reported
  • Use messageId
  • Move customError check to selector

@fisker fisker changed the title throw-new-error: Check MemberExpression throw-new-error: Check MemberExpression customError May 4, 2020
@fisker fisker force-pushed the throw-new-error-improve-0504 branch from 1b5d9b3 to 6b8655b Compare May 4, 2020 09:10
@sindresorhus sindresorhus merged commit a28aad5 into sindresorhus:master May 4, 2020
@fisker fisker deleted the throw-new-error-improve-0504 branch May 4, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants