New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-useless-undefined
rule
#718
Merged
sindresorhus
merged 22 commits into
sindresorhus:master
from
fisker:rules/no-useless-undefined
May 6, 2020
Merged
Add no-useless-undefined
rule
#718
sindresorhus
merged 22 commits into
sindresorhus:master
from
fisker:rules/no-useless-undefined
May 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
force-pushed
the
rules/no-useless-undefined
branch
from
May 4, 2020 17:08
ea4875b
to
9c448de
Compare
fisker
force-pushed
the
rules/no-useless-undefined
branch
from
May 4, 2020 17:15
9c448de
to
72af77e
Compare
Ready for review, hope I get everything covered, really lots of cases. I'll fix lint issue when it's approved. |
sindresorhus
reviewed
May 5, 2020
sindresorhus
approved these changes
May 5, 2020
…-plugin-unicorn into rules/no-useless-undefined
To make this rule work together with
I suggest do |
yakov116
reviewed
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
xojs/eslint-config-xo@f3c5dd2 Will be part of the next minor XO release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683