unicorn/no-fn-reference-in-iterator - wrong context

[lagden]

The lint is claiming a MongoDB query (.find)

// Example
// error  Do not pass function `collection` directly to `.find(…)`  unicorn/no-fn-reference-in-iterator
const results = await collection
  .find({
    $and: [cursorQuery, params.query]
  }, {
    projection: params.projection
  })
  .sort($sort)
  .limit(params.limit + 1)
  .toArray()

[fisker]

I can make a PR to ignore objects for now, but

const results = await collection
  .find(
   foo,  // <-- we  can't tell  what this  is
    {
    projection: params.projection
  })
  .sort($sort)
  .limit(params.limit + 1)
  .toArray()

still get reported.

[fisker]

This message in issue description might misleading, the message is actually

error  Do not pass function directly to `.find(…)`  unicorn/no-fn-reference-in-iterator

[lagden]

The message is from eslint.

[fisker]

- error  Do not pass function `collection` directly to `.find(…)`  unicorn/no-fn-reference-in-iterator
+ error  Do not pass function directly to `.find(…)`  unicorn/no-fn-reference-in-iterator

There is no function name in that message.

I thought that's also a bug, so I had to test it.

[lagden]

@fisker sorry!!

I copied error from other block!! my bad!

// error  eslint:unicorn/no-fn-reference-in-iterator  Do not pass function `collection` directly to `.find(…)`.
const collection = t.context.db.collection('test_paging')
let res = await paging.find(collection, {
  limit: 3
})

[fisker]

No problem. As I comment above, if you use object in .find({}) , it will ignored in #756. But .find(foo) will still be a problem, you'll have to use //eslint-disable.

[aleksandr-omise]

With D3 delaunay error too.

const delaunay = Delaunay.from(
  valuesWithCoord,
  (el) => el.x,
  (el) => el.y
)

const nearestPointIndex = delaunay.find(x, y)

I guess nothing can do about it.