prevent-abbreviations: Fix optional parameter
#764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Jun 2, 2020
| @@ -28,7 +28,7 @@ function renameIdentifier(identifier, name, fixer, sourceCode) { | |||
|
|
|||
| // `typeAnnotation` | |||
| if (identifier.typeAnnotation) { | |||
| return fixer.replaceText(identifier, `${name}${sourceCode.getText(identifier.typeAnnotation)}`); | |||
| return fixer.replaceText(identifier, `${name}${identifier.optional ? '?' : ''}${sourceCode.getText(identifier.typeAnnotation)}`); | |||
There was a problem hiding this comment.
This is kinda fragile. I'm surprised ESLint doesn't have a fixer utility to simply rename a node. If we could just set the identifier.name property instead, we wouldn't have to specially handle identifier.optional and identifier.typeAnnotation.
What do you think about proposing such utility to ESLint?
There might also be other rules of ours where we need to handle identifier.optional
There was a problem hiding this comment.
There might be a way to modify the node, render it and then use teplaceText. The only tricky part is to choose the right renderer for JS/TS. This begs for a utility module
There was a problem hiding this comment.
@futpib What do you mean render? Get the original text?
sindresorhus
changed the title
prevent-abbreviations: fix optional parameterprevent-abbreviations: Fix optional parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763