Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe replacement with .startsWith() when doing xo --fix #782

Closed
timlesallen opened this issue Jun 24, 2020 · 4 comments · Fixed by #783
Closed

Unsafe replacement with .startsWith() when doing xo --fix #782

timlesallen opened this issue Jun 24, 2020 · 4 comments · Fixed by #783
Labels
bug

Comments

@timlesallen
Copy link
Contributor

timlesallen commented Jun 24, 2020 •
edited

/^NN|VB/.test(partOfSpeech) → partOfSpeech.startsWith('NN|VB')

This actually broke my code. :)

I hope I'm filing this in the right place. Or should it rather be under xo?
@timlesallen timlesallen changed the title Unsafe replacement with .startsWith when doing xo --fix Unsafe replacement with .startsWith() when doing xo --fix Jun 24, 2020
@timlesallen timlesallen changed the title Unsafe replacement with .startsWith() when doing xo --fix Unsafe replacement with .startsWith() when doing xo --fix Jun 24, 2020
@fisker fisker added the bug label Jun 24, 2020
@fisker
Copy link
Collaborator

fisker commented Jun 24, 2020

This is the right place.

@fisker
Copy link
Collaborator

fisker commented Jun 24, 2020

Would you like to send a PR fix this? This is easy one, just add | to

eslint-plugin-unicorn/rules/prefer-starts-ends-with.js

Line 14 in 4594085

['^', '$', '+', '[', '{', '(', '\\', '.', '?', '*']

@timlesallen
Copy link
Contributor Author

@fisker Ok will do.

@timlesallen timlesallen mentioned this issue Jun 24, 2020
Merged
@timlesallen
Copy link
Contributor Author

@fisker There you go :) #783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prefer-starts-ends-with: Fix pipe in regex timlesallen/eslint-plugin-unicorn
2 participants
@fisker @timlesallen