Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-array-callback-reference: Ignore AwaitExpression except reduce and reduceRight #814

Merged
merged 5 commits into from Jan 11, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Sep 1, 2020

Fixes #813

@fisker fisker marked this pull request as draft September 1, 2020 03:06
@fisker
Copy link
Collaborator Author

fisker commented Sep 1, 2020

I set this as draft for now, there are new cases coming up, see #813 (comment)

@sindresorhus
Copy link
Owner

I think the discussion in #813 has been resolved, so this could be moved forward.

@RobertoMachorro
Copy link

I think the discussion in #813 has been resolved, so this could be moved forward.

@sindresorhus does this mean this draft will be merged? Or is the solution something else? Thanks!

@sindresorhus
Copy link
Owner

@sindresorhus does this mean this draft will be merged? Or is the solution something else? Thanks!

It means that this PR needs to be updated based on the resolution in #813.

@fisker fisker changed the title no-fn-reference-in-iterator: Ignore AwaitExpression no-array-callback-reference: Ignore AwaitExpression Jan 11, 2021
@fisker fisker changed the title no-array-callback-reference: Ignore AwaitExpression no-array-callback-reference: Ignore AwaitExpression except reduce and reduceRight Jan 11, 2021
@fisker fisker marked this pull request as ready for review January 11, 2021 08:46
@sindresorhus sindresorhus merged commit 4c2b00b into sindresorhus:master Jan 11, 2021
@fisker fisker deleted the issue-813 branch January 11, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unicorn/no-fn-reference-in-iterator mistaking .find method?
3 participants