Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-nested-ternary: Improve report location & message #844

Merged
merged 5 commits into from
Sep 30, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Sep 30, 2020

  • Simplify logic
  • Report on third level ternary instead of first level one
  • Add different message for "not parenthesized" ternary

Update:

Only report on third-level ternary, avoid reporting same problem multiple times. 931dc4a

@sindresorhus
Copy link
Owner

Looks good. Can you fix the merge conflict?

# Conflicts:
#	test/snapshots/no-nested-ternary.js.md
#	test/snapshots/no-nested-ternary.js.snap
@sindresorhus sindresorhus merged commit ca1afa6 into sindresorhus:master Sep 30, 2020
@fisker fisker deleted the no-nested-ternary branch September 30, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants