explicit-length-check: Use 'non-zero': 'greater-than' by default
#850
+25
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgenyOrekhov
commented
Oct 4, 2020
| if (array.length === 0) {} | ||
| ``` | ||
|
|
||
|
|
||
| ## Zero comparisons | ||
|
|
||
| Enforce comparison with `!== 0` when checking for zero length. | ||
| Enforce comparison with `=== 0` when checking for zero length. |
There was a problem hiding this comment.
I believe this was a typo because this section talks about zero comparisons. So I fixed it.
EvgenyOrekhov
commented
Oct 4, 2020
| @@ -35,13 +35,13 @@ if (string.length < 1) {} | |||
| ### Pass | |||
|
|
|||
| ```js | |||
| if (array.length !== 0) {} | |||
| if (array.length === 0) {} | |||
There was a problem hiding this comment.
I believe this was a typo because this section talks about zero comparisons. So I fixed it.
EvgenyOrekhov
deleted the
702-explicit-length-check-greater-than-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is a breaking change since the rule wasn't enforcing any non-zero comparison style by default before, but now it enforces the
greater-thanstyle.Fixes #702