Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false import styles seen in reported problem messages #910

Merged
merged 2 commits into from Dec 7, 2020
Merged

Fix false import styles seen in reported problem messages #910

merged 2 commits into from Dec 7, 2020

Conversation

futpib
Copy link
Collaborator

@futpib futpib commented Nov 30, 2020

Fixes #899 (Alternative fix)

fisker
fisker approved these changes Dec 7, 2020
View reviewed changes
Copy link
Collaborator

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can remove the unused key?

rules/import-style.js Outdated Show resolved Hide resolved
@fisker fisker merged commit d669707 into sindresorhus:master Dec 7, 2020
@FloEdelmann FloEdelmann mentioned this pull request Dec 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisker fisker fisker approved these changes

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@futpib @sindresorhus @fisker