explicit-length-check: Check Set#size

[fisker]

Make explicit-length-check rule work for Set#size

We can't tell foo in foo.size is a Set, but it seems safe to assume .size is an integer.

Ref: #952 (comment)

[0-Arngerdur-1]

I am new with JavaScript, but i would like to help with this issue. I can?

[fisker]

Go ahead.

[0-Arngerdur-1]

Thanks, I have a question, where is the set#size rule? I already looked for it in the comment file and I can't find it.

[fisker]

explicit-length-check

[0-Arngerdur-1]

I am working on the issue, I would like to ask some questions, can I?

[fisker]

Shot

[0-Arngerdur-1]

As I understand, in base of the comment in the #952, you tell two improvements for the rule "explicit-length-check" , located in the file 'eslint-plugin-unicorn/rules/explicit-length-check.js', one of these is remove the option >=1 and the other is make the rule work for Set#size. The first one I understand, if I'm not wrong, is only remove the option 'greater-than-or-equal' in the Map and in the function getLengthCheckNode. The second improve I don't understand completely well, but after analyzing it I concluded that you mean is that based on a given Set then instead of just checking non-zero, also check according of the Set values, for example, greater than 5, greater than 6 and so on. I'm right?