prefer-string-starts-ends-with: Fix missing parentheses for some cases
#976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
force-pushed
the
prefer-string-starts-ends-with-parens
branch
from
1194a0f
to
1011896
Compare
fisker
force-pushed
the
prefer-string-starts-ends-with-parens
branch
3 times, most recently
from
35b9e29
to
5b3df26
Compare
fisker
force-pushed
the
prefer-string-starts-ends-with-parens
branch
from
5b3df26
to
b27b35c
Compare
fisker
force-pushed
the
prefer-string-starts-ends-with-parens
branch
from
2cc4b85
to
bc58ccd
Compare
fisker
force-pushed
the
prefer-string-starts-ends-with-parens
branch
from
d3a7065
to
f0bf5d6
Compare
rules/utils/need-add-parentheses-to-member-expression-object.js
Outdated
Show resolved
Hide resolved
rules/utils/need-add-parentheses-to-member-expression-object.js
Outdated
Show resolved
Hide resolved
|
|
||
| case 'Literal': { | ||
| /* istanbul ignore next */ | ||
| if (typeof node.value === 'number' && /^\d+$/.test(node.raw)) { |
There was a problem hiding this comment.
Won't this fail on 1.1 or 1e+2 and more? If this is intentional, it would be good with a code comment.
There was a problem hiding this comment.
Yes, 1.1.toString(); an 2e+2.toString(); are valid.
There was a problem hiding this comment.
Found a better one in eslint core, https://github.com/eslint/eslint/blob/cc4871369645c3409dc56ded7a555af8a9f63d51/lib/rules/no-extra-parens.js#L1011, I didn't consider numberic seperators.
no-extra-parens rule use the same pattern in initial commit. 😄
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
fisker
force-pushed
the
prefer-string-starts-ends-with-parens
branch
from
1c061de
to
5b524af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this bug during #970
is fixed to
Should be
I didn't add to many cases in
needAddParenthesesToMemberExpressionObject, for now, only some nodes can bestring. I believe there are other rules need this, we'll add more when we need.