diff --git a/rules/prefer-query-selector.js b/rules/prefer-query-selector.js index 3555a70896..6a51a2da87 100644 --- a/rules/prefer-query-selector.js +++ b/rules/prefer-query-selector.js @@ -105,6 +105,11 @@ const create = context => { return; } + const [firstArgument] = node.arguments; + if (node.arguments.length !== 1 || firstArgument.type === 'SpreadElement') { + return; + } + const report = { node, messageId: MESSAGE_ID, diff --git a/test/prefer-query-selector.js b/test/prefer-query-selector.js index 4ef12dd69b..a00955dcb3 100644 --- a/test/prefer-query-selector.js +++ b/test/prefer-query-selector.js @@ -7,6 +7,11 @@ const createError = (method, replacement) => ({ test({ valid: [ + // More or less arguments + 'document.getElementById();', + 'document.getElementsByClassName("foo", "bar");', + 'document.getElementById(...["id"]);', + 'document.querySelector("#foo");', 'document.querySelector(".bar");', 'document.querySelector("main #foo .bar");',