Add promise-based IPC #1059
Merged
Add promise-based IPC #1059
+1,093
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
May 16, 2024
| @@ -70,7 +70,6 @@ | |||
| "c8": "^9.1.0", | |||
| "get-node": "^15.0.0", | |||
| "is-running": "^2.1.0", | |||
| "p-event": "^6.0.0", | |||
There was a problem hiding this comment.
devDependencies used only in tests. Replaced by once() from node:events.
ehmicky
commented
May 16, 2024
| [More info.](https://nodejs.org/api/child_process.html#subprocesssendmessage-sendhandle-options-callback) | ||
| */ | ||
| send: HasIpc<OptionsType> extends true ? ChildProcess['send'] : undefined; |
There was a problem hiding this comment.
This is not a breaking change: Subprocess['send'] is still defined due to the & ChildProcess line below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1053.
This adds the following methods:
subprocess.sendMessage(message),subprocess.getOneMessage(),subprocess.getEachMessage().sendMessage(message),getOneMessage(),getEachMessage().This also exports a new type
Messagerepresenting IPC messages.The old IPC methods are undocumented but kept. This PR does not have any breaking change.