Skip to content

Update required Node.js semver range to "^18.19.0 || >=20.5.0" #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2024
Merged

Update required Node.js semver range to "^18.19.0 || >=20.5.0" #1101

merged 1 commit into from
May 26, 2024

Conversation

iiroj
Copy link
Contributor

@iiroj iiroj commented May 26, 2024

Fixes #1097 by updating the package.json engines.node semver range to match the currently supported Node.js versions: ^18.19.0 || >=20.5.0

@ehmicky
Copy link
Collaborator

ehmicky commented May 26, 2024

@sindresorhus Is this technically a breaking change for users that use engine-strict: true? In principle, that means they are using an unsupported Node.js version, which should not work at all. So I guess it's ok, just wanted to point it out.

@iiroj iiroj changed the title Update required Node.js semver range to "^18.9.0 || >=20.5.0" Update required Node.js semver range to "^18.19.0 || >=20.5.0" May 26, 2024
@iiroj
Copy link
Contributor Author

iiroj commented May 26, 2024

My personal opinion is that it was communicated in the changelog for version 9, so this is just a fix to make sure the value is up-to-date.

@ehmicky
Copy link
Collaborator

ehmicky commented May 26, 2024

Good point @iiroj.

@sindresorhus sindresorhus merged commit 691af8a into sindresorhus:main May 26, 2024
8 checks passed
@iiroj iiroj deleted the engines-node-semver branch May 27, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js engine version in package.json is not up-to-date
3 participants