Skip to content

Improve cancelSignal option #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2024
Merged

Improve cancelSignal option #1108

merged 1 commit into from
May 28, 2024
+146 −14

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 28, 2024

This PR improves the cancelSignal option:

  • Does not emit the error event on the subprocess, so it does not disconnect IPC since some messages might still be buffered
  • Does not spawn the subprocess when passing an invalid cancelSignal type
  • Make error.message contain the error message passed to abortController.abort(), instead of error.cause.message
  • Clean up listeners on the AbortSignal even when the subprocess fails while spawning

@ehmicky
Improve cancelSignal option
Loading
Loading status checks…
5f5f5b7
@sindresorhus sindresorhus merged commit 3b56977 into main May 28, 2024
14 checks passed
@sindresorhus sindresorhus deleted the cancel-signal branch May 28, 2024 10:48
@Ramyromel Ramyromel mentioned this pull request Aug 28, 2024
Merged
@gr00nd gr00nd mentioned this pull request Sep 13, 2024
Open
@tunnckoCore tunnckoCore mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmicky @sindresorhus