Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature proposal] Improved error messages #177

Closed
ehmicky opened this issue Feb 25, 2019 · 2 comments · Fixed by #180
Closed

[Feature proposal] Improved error messages #177

ehmicky opened this issue Feb 25, 2019 · 2 comments · Fixed by #180

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Feb 25, 2019

The current code has some logic aimed at providing better error messages. It would be nice to add the following error messages:

  • Command timed out after 5 seconds: ... if timedOut is true.
  • Command was killed with SIGTERM if signal is not null.
  • Command failed with exit code 2 (ENOENT) otherwise.

The values (e.g. SIGTERM) in the messages above are for example purpose.

I can provide with a PR if this feature proposal is approved.

@sindresorhus
Copy link
Owner

👍 Good idea. PR welcome.

@ehmicky
Copy link
Collaborator Author

ehmicky commented Feb 28, 2019

Done at #180

@ehmicky ehmicky closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants