Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for options.localDir #218

Merged
merged 3 commits into from May 7, 2019
Merged

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 7, 2019

This improves the unit test for options.localDir:

  • remove test.serial() and npm install to make the test much faster
  • use a simpler approach that only relies on checking the $PATH environment variable instead of firing a command.

@ehmicky ehmicky requested a review from sindresorhus May 7, 2019 10:57
@sindresorhus sindresorhus merged commit 0070738 into master May 7, 2019
@sindresorhus sindresorhus deleted the feature/fix-localdir-test branch May 7, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants