Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for the reject option #233

Merged
merged 1 commit into from May 11, 2019
Merged

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 10, 2019

This improves the unit tests for the reject option, making them simpler. Also one of the test was incorrect (it would not throw, even without the reject option).

@ehmicky ehmicky requested a review from sindresorhus May 10, 2019 17:40
@sindresorhus sindresorhus merged commit e55dc8b into master May 11, 2019
@sindresorhus sindresorhus deleted the feature/reject-tests branch May 11, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants