Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests more consistent (code refactoring) #247

Merged
merged 2 commits into from May 14, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 14, 2019

This is a code refactoring PR that is only style-related.

  • it makes the style of tests more consistent with each other.
  • it uses destructuring whenever possible.

Also:

  • it tests error.exitCode (new property) instead of error.code (deprecated property)
  • it splits one test into two (because it was two tests combined in one)

test.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@sindresorhus sindresorhus merged commit f5172cd into master May 14, 2019
@sindresorhus sindresorhus deleted the feature/improve-tests branch May 14, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants