Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TODO comment about spawned.stdin bug being fixed in Node.js 12 #258

Merged
merged 2 commits into from May 20, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 20, 2019

#212 will not be needed anymore after the next release of Node.js (12.3.0 probably). This was fixed in Node.js by this PR.

This adds a TODO comment to remove it once we drop support for Node.js <= 12.2.0. Granted this won't be in the immediate future :)

@sindresorhus sindresorhus changed the title Add TODO comment about spawned.stdin bug being fixed in Node 12 Add TODO comment about spawned.stdin bug being fixed in Node.js 12 May 20, 2019
@sindresorhus sindresorhus merged commit 50e3ef4 into master May 20, 2019
@sindresorhus sindresorhus deleted the feature/todo-stdin-bug branch May 20, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants