Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming error.command #265

Closed
ehmicky opened this issue May 24, 2019 · 2 comments
Closed

Renaming error.command #265

ehmicky opened this issue May 24, 2019 · 2 comments
Labels
enhancement question

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented May 24, 2019

Should error.command be renamed to error.file, error.script or error.program? For two reasons:

  1. We now have execa.command() and having both is a little confusing both in the README.
  2. A command is technically an executable file + its arguments.

This applies also to result.command.
@sindresorhus
Copy link
Owner

Yes, I would go with .file.

@ehmicky
Copy link
Collaborator Author

ehmicky commented Jun 10, 2019

It turns out error.command is in fact the file but also its arguments. So it should not be renamed to .file.

Since we both got confused, I've added two PRs to make both the code and the README clearer: #278 and #279.

@ehmicky ehmicky closed this as completed Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @ehmicky