Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge forceKill and forceKillAfter options #285

Merged
merged 4 commits into from Jun 14, 2019
Merged

Merge forceKill and forceKillAfter options #285

merged 4 commits into from Jun 14, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Jun 12, 2019

This comes from a discussion with @sindresorhus.

Merges forceKill (boolean) and forceKillAfter (number) into forceKillAfterTimeout (boolean | number`).

sindresorhus
sindresorhus reviewed Jun 13, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Jun 13, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
ehmicky and others added 3 commits June 13, 2019 10:34
@ehmicky @sindresorhus
Update index.d.ts
bd2b2d3 
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@ehmicky @sindresorhus
Update readme.md
67f274c 
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@ehmicky
Fix TypeScript tests
5ef1c83
@ehmicky
Copy link
Collaborator Author

ehmicky commented Jun 13, 2019

Fixed.

@sindresorhus sindresorhus merged commit 0336882 into master Jun 14, 2019
@sindresorhus sindresorhus deleted the feature/force-kill-options branch June 14, 2019 06:48
@ehmicky ehmicky mentioned this pull request Jun 14, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmicky @sindresorhus