Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: setTimeout(...).unref is not a function #399

Closed
mifi opened this issue Dec 18, 2019 · 4 comments
Closed

TypeError: setTimeout(...).unref is not a function #399

mifi opened this issue Dec 18, 2019 · 4 comments

Comments

@mifi
Copy link
Sponsor Contributor

mifi commented Dec 18, 2019

I use this module all the time including in Electron. After upgrading to the newest version i get this error when trying to call childprocess.kill() from an Electron application:

TypeError: setTimeout(...).unref is not a function
setKillTimeout
.../node_modules/execa/lib/kill.js:23:14

Note: with execa@1 it works. But 2 or 3 fails with this error. Maybe we could add a check for whether unref exists before calling it, or is Electron not supported anymore?

@mifi mifi mentioned this issue Dec 18, 2019
@mifi
Copy link
Sponsor Contributor Author

mifi commented Dec 18, 2019

I created a PR to fix

@ehmicky
Copy link
Collaborator

ehmicky commented Dec 18, 2019

Thanks a lot @mifi!

@sindresorhus
Copy link
Owner

Fixed by #400

@ehmicky
Copy link
Collaborator

ehmicky commented Dec 19, 2019

Published in v4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants