Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AbortController #490

Merged
merged 21 commits into from Feb 13, 2022
Merged

Support AbortController #490

merged 21 commits into from Feb 13, 2022

Conversation

jopemachine
Copy link
Contributor

Fixes #449.

I'd appreciate it if you could let me know if I need to write more tests or documents.

Thanks for all your efforts for this awesome library :)

@ehmicky
Copy link
Collaborator

ehmicky commented Feb 4, 2022

Thanks a lot for this contribution @jopemachine!

We might want to name this option signal instead of abortSignal to match the name currently used by child_process.spawn().

More fundamentally, I am wondering whether the core signal option should just be used instead? I have written some potential ideas in the issue, please let me know what you think.

@jopemachine
Copy link
Contributor Author

We might want to name this option signal instead of abortSignal to match the name currently used by child_process.spawn().

Thanks for pointing it out, I just updated the option.

index.d.ts Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@jopemachine
Copy link
Contributor Author

Should I delete this document too? or should I mark the cancel method as deprecated?

index.js Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
test/kill.js Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can directly delete that section of the documentation, good catch! 👍

Thanks again for this PR @jopemachine! There are a couple of things I have noted.
The tests look great! (But the CI tests are currently failing)

@jopemachine
Copy link
Contributor Author

I believe we can directly delete that section of the documentation, good catch! 👍

Thanks again for this PR @jopemachine! There are a couple of things I have noted. The tests look great! (But the CI tests are currently failing)

I appreciate your detailed feedback :)
I tried to reflect on all the feedback as much as I can.
If I'm missing something or got something wrong, I appreciate your letting me know.

index.js Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test/kill.js Outdated Show resolved Hide resolved
@ehmicky
Copy link
Collaborator

ehmicky commented Feb 7, 2022

Thanks a lot for those edits, they look great! And the tests are now passing on Node 16 🎉
I have a few more comments, but we're getting there. Thanks for your help @jopemachine.

index.js Show resolved Hide resolved
Copy link
Collaborator

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks a lot @jopemachine!

Now waiting for another review from @sindresorhus.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit c6e791a into sindresorhus:main Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AbortController
3 participants