New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AbortController
#490
Support AbortController
#490
Conversation
Thanks a lot for this contribution @jopemachine! We might want to name this option More fundamentally, I am wondering whether the core |
Thanks for pointing it out, I just updated the option. |
Should I delete this document too? or should I mark the cancel method as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can directly delete that section of the documentation, good catch! 👍
Thanks again for this PR @jopemachine! There are a couple of things I have noted.
The tests look great! (But the CI tests are currently failing)
I appreciate your detailed feedback :) |
Thanks a lot for those edits, they look great! And the tests are now passing on Node 16 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks a lot @jopemachine!
Now waiting for another review from @sindresorhus.
Fixes #449.
I'd appreciate it if you could let me know if I need to write more tests or documents.
Thanks for all your efforts for this awesome library :)