Drop support for Node 12 #497
Conversation
| @@ -3,7 +3,6 @@ import process from 'node:process'; | |||
| import {fileURLToPath} from 'node:url'; | |||
| import test from 'ava'; | |||
| // The helper module overrides Promise on import so has to be imported before `execa`. | |||
| // Can't use top-level await (TLA) + `import(…)` since Node.js 12 doesn't support TLA. | |||
There was a problem hiding this comment.
I do not see how a top-level await could be used in this instance, so I just removed the comment.
| @@ -167,9 +166,7 @@ if (process.platform !== 'win32') { | |||
| }); | |||
|
|
|||
| test('execa() rejects with correct error and doesn\'t throw if running non-executable with input', async t => { | |||
| // On Node <12.6.0, `EACCESS` is emitted on `childProcess`. | |||
| // On Node >=12.6.0, `EPIPE` is emitted on `childProcess.stdin`. | |||
There was a problem hiding this comment.
This comment was invalid: EACCES is used on Node >=12.6.0, and EPIPE on <12.6.0.
.github/workflows/main.yml
Outdated
| - 12 | ||
| - 18.0.0 | ||
| - 16.4.0 | ||
| - 14.18.0 |
There was a problem hiding this comment.
I would prefer using non-specific minors so it upgrades when new minor versions are out.
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
|
How did you not publish a breaking change for months? I'm still learning Semantic Versioning but if I was to merge a breaking change it'd be immediately added to releases Only now am I getting a dependency PR for this |
|
Hi @BrycensRanch, |
|
oh |
|
Hi! I see you mentioned dropping support for node < 16.3, but on |
This drops support for Node 12 (breaking change) since it is not maintained anymore.
This also adds CI tests for Node 18, and upgrades some GitHub actions.
The also drops Node
14.13.1 - 14.17.0and16.0.0 - 16.3.0in order to support unconditionally several features:cwd: URL,stdio: 'overlapped'and thesignaloption.