Fix incorrect execaNode signature in index.d.ts
#506
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing |
ehmicky
reviewed
Jul 28, 2022
index.test-d.ts
Outdated
| @@ -210,3 +210,7 @@ expectType<ExecaReturnValue>( | |||
| expectType<ExecaReturnValue<Buffer>>( | |||
| await execaNode('unicorns', ['foo'], {encoding: null}), | |||
| ); | |||
| execaNode('unicorns', {nodeOptions: ['--async-stack-traces']}) | |||
There was a problem hiding this comment.
Suggested change
| execaNode('unicorns', {nodeOptions: ['--async-stack-traces']}) | |
| execaNode('unicorns', {nodeOptions: ['--async-stack-traces']}); |
|
Bump |
|
thanks for the bump! looking now |
forivall
force-pushed
the
fix/dts-nodeoptions
branch
from
77b5bfb to
1e28244
Compare
ehmicky
approved these changes
Dec 26, 2022
|
@sindresorhus Is this ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All signatures of
execaNodesupportnodeOptions(andnodePath)