New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default value of stdin
with $
#550
Conversation
@@ -27,7 +27,7 @@ export type CommonOptions<EncodingType> = { | |||
|
|||
If you `$ npm install foo`, you can then `execa('foo')`. | |||
|
|||
@default `true` with `$`/`$.sync`, `false` otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think $.sync
is implied by $
, so I am not sure we need to be explicit there.
I would see it as a bug-fix. |
Can you fix the merge conflict? Feel free to merge and release afterwards. |
7a630a3
to
284ebf6
Compare
Just for the record, we have a scenario in which we use the change on our side was just clearly defining the flags for execa as
and this would bring the behaviour back to what we where previously doing before this PR was merged Leaving this here just for if anyone else is affected some references: |
Fixes #549
This makes
stdin
of processes created with$
default toinherit
instead ofpipe
, as this is most likely the intended behavior of users in that case.This is technically a breaking change from
7.1.0
. However, considering this is a very recent release and this is correcting the intended behavior, I am not sure whether we can consider7.1.0
's behavior a bug, i.e. this would be a bug fix instead? 馃