Fix stdio option
#634
Merged
Fix stdio option
#634
+186
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
stdiooption. Its types are currently incorrect.Also, when passing more than 3 values to the
stdiooption (i.e. creating custom file descriptors), the additional values should work like thestdin/stdout/stderroptions, e.g. allow web streams, file paths, file URLs, etc.This PR also adds a better error message when users pass a Node.js stream to
execaSync().child_process.spawnSync()already forbids it, but the error message is less clear.