Limit breaking changes with types #682
Merged
+96
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
force-pushed
the
sync-types-refactor
branch
from
83de881 to
2cc7dc0
Compare
|
Fixed conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ExecaSyncReturnValue,ExecaSyncErrorandSyncOptionstypes are for sync methods.The
ExecaReturnValue,ExecaErrorandOptionstypes used to be for async methods. However, with #678, they are now for what's common between the async and sync methods. Based on your comment at #678 (comment), I reintroduced the sync methods types. This PR does the second step: to ensure those types remain for the async methods only, so that's it's not a breaking change. Also, it makes more sense, since most users need either the async types or the sync ones, not both.