Handle stream errors even with buffer: false
#729
Merged
+41
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
force-pushed
the
handle-stream-errors
branch
from
2fe37eb to
9287535
Compare
ehmicky
commented
Jan 24, 2024
| // - `all` is `true` | ||
| // - `buffer` is `false` | ||
| // - `childProcess.all` is not read by the user | ||
| // Therefore, we forcefully resume `childProcess.all` flow on errors. |
There was a problem hiding this comment.
This took me some time to figure out!
ehmicky
force-pushed
the
handle-stream-errors
branch
from
9287535 to
158f2a2
Compare
ehmicky
force-pushed
the
handle-stream-errors
branch
from
158f2a2 to
27f91fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #716.