Add ipc option
#794
Merged
Add ipc option
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Feb 7, 2024
| @@ -309,7 +309,6 @@ type CommonOptions<IsSync extends boolean = boolean> = { | |||
| - `'pipe'`: Sets [`childProcess.stdin`](https://nodejs.org/api/child_process.html#subprocessstdin) stream. | |||
| - `'overlapped'`: Like `'pipe'` but asynchronous on Windows. | |||
| - `'ignore'`: Do not use `stdin`. | |||
| - `'ipc'`: Sets an [IPC channel](https://nodejs.org/api/child_process.html#subprocesssendmessage-sendhandle-options-callback). You can also use `execaNode()` instead. | |||
There was a problem hiding this comment.
Undocument passing ipc to the stdio option. However, it is still supported.
ehmicky
commented
Feb 7, 2024
| @@ -286,6 +288,12 @@ export function execaSync(rawFile, rawArgs, rawOptions) { | |||
| }; | |||
| } | |||
|
|
|||
| const validateSyncOptions = ({ipc}) => { | |||
| if (ipc) { | |||
| throw new TypeError('The "ipc: true" option cannot be used with synchronous methods.'); | |||
There was a problem hiding this comment.
child_process.spawnSync() does not allow IPC. It would not make sense anyway, since childProcess.send() would not be available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #782.